Skip to content

[PHPStan] Regenerated baseline #2817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

[PHPStan] Regenerated baseline #2817

merged 1 commit into from
Jul 16, 2025

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Jul 10, 2025 •
edited
Loading

Target: 4.6, 5.0

PHPStan is currently failing with:

 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------
  Line   discounts/src/Command/ManageDiscountsCommand.php
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------
  60     Class Ibexa\Contracts\DiscountsCodes\Value\Struct\DiscountCodeCreateStruct constructor invoked with 4 parameters, 5 required.
         🪪 arguments.count
  64     Parameter #4 $creatorId of class Ibexa\Contracts\DiscountsCodes\Value\Struct\DiscountCodeCreateStruct constructor expects int|null, DateTimeImmutable given.
         🪪 argument.type
  81     Class Ibexa\DiscountsCodes\Value\DiscountCondition\IsValidDiscountCode constructor invoked with 2 parameters, 3 required.
         🪪 arguments.count
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------

The code fixes are done in #2810 , but they cannot be merged yet - because we must wait for 4.6.22 before we merge.

Because of that, I'm adding these issues to the baseline, so that the we don't miss something else important

@github-actions
Copy link

Preview of modified files: no change to preview.

@mnocon mnocon marked this pull request as ready for review July 10, 2025 08:12
@mnocon mnocon requested a review from a team July 10, 2025 08:13
@ezrobot ezrobot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team July 10, 2025 08:13
@mnocon mnocon merged commit cd6d995 into 4.6 Jul 16, 2025
11 checks passed
@mnocon mnocon deleted the fix-phpstan branch July 16, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@julitafalcondusza julitafalcondusza julitafalcondusza approved these changes

@adriendupuis adriendupuis Awaiting requested review from adriendupuis

@dabrt dabrt Awaiting requested review from dabrt

Assignees

No one assigned

Labels

Needs DOC review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnocon @Steveb-p @julitafalcondusza